Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker 7.x #181

Closed
jonathangreen opened this issue May 23, 2024 · 4 comments · Fixed by #182
Closed

Support docker 7.x #181

jonathangreen opened this issue May 23, 2024 · 4 comments · Fixed by #182

Comments

@jonathangreen
Copy link
Contributor

Docker 7.1.0 contains a fix necessary to use the latest version of requests. tox-docker not supporting docker 7.x is keeping my project from being able to update. Would it be possible to support docker 7.x in tox-docker?

@jonathangreen
Copy link
Contributor Author

Some info about the issue resolved in docker 7.1.0 here:
docker/docker-py#3257
psf/requests#6707

@infinityplusone
Copy link

Thanks for posting this! I was coming to do the same.

The full/longer description of the issue started here: docker/docker-py#3256.

From what I can tell, those of us using tox-docker can't benefit from the docker fix until tox-docker supports Docker 7.x.

@jonathangreen
Copy link
Contributor Author

I put up a small PR to resolve this one here: #182

@dcrosta
Copy link
Member

dcrosta commented May 25, 2024

OK, I've just published https://pypi.org/project/tox-docker/5.0.0/ with this fix.

5.0 removes support for tox 3, and has a breaking change if you were using ports in your tox.ini. Check the README for details on how to use the replacement.

Many thanks @jonathangreen for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants