Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cancel support enforcers with "don't support bridges" #5105

Closed
Shama71 opened this issue Nov 7, 2020 · 10 comments
Closed

Don't cancel support enforcers with "don't support bridges" #5105

Shama71 opened this issue Nov 7, 2020 · 10 comments
Labels

Comments

@Shama71
Copy link

Shama71 commented Nov 7, 2020

Version

2.3.0-alpha3+win64

Operating system type + version

Windows 10

Behavior

Custom supports by painting no support with 0.2mm.
For other layer height support is correct.

Project File (.3MF) where problem occurs

Is correct
Layer height 0 24

No support
Layer height 0 20

Bug - Support.zip

@lukasmatena
Copy link
Collaborator

This also appears when using good-old custom box enforcers, so it is not a bug in the new painter. Even a small change from 0.2 mm fixes it.

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 11, 2020

Maybe you have "dont't support bridges' enabled?

@Shama71
Copy link
Author

Shama71 commented Dec 11, 2020

Maybe you have "dont't support bridges' enabled?

Yes it is included, but sometimes support was needed for large bridges, but not needed for normal ones.

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 11, 2020 via email

@minosg
Copy link

minosg commented Jan 18, 2021

@bubnikv

Out of curiosity, what would be the design requirements for that logic?

I understand the logic behind the automatic support planner not generating support for every bridge feature. But, if a user wants to print a cup type object, and using "Support enforcers only", explicitly define his own supports, why would this option stop him from doing so?

@bubnikv
Copy link
Collaborator

bubnikv commented Jan 19, 2021

Out of curiosity, what would be the design requirements for that logic?

It was not by design, it was by implementation. The implementation of support enforcers was significantly simpler that way. We may change the behavior in the future.

@minosg
Copy link

minosg commented Jan 19, 2021

@bubnikv thanks for the prompt response. That makes more sense. Since it is not hard to workaround by disabling that checkbox, it shouldn't be a high priority task.

There may be some value in disabling that box in the default profiles though, or adding some context in the tool tip, to avoid duplicate ticket/bug reports from new users.

@bubnikv bubnikv changed the title No support with 0.2mm for custom supports by painting Don't cancel support enforcers with "don't support bridges" Feb 24, 2021
@bubnikv
Copy link
Collaborator

bubnikv commented Mar 18, 2021

The support enforcers newly take precedence over "don't support bridges" and "on build plate only".

image

@Shama71
Copy link
Author

Shama71 commented Mar 18, 2021

Actually, in the first message, I pointed out that when the height of the layer changes, the behavior of the support placement changes.

bubnikv added a commit that referenced this issue Mar 19, 2021
1) If "support on build plate only" is enabled, the support columns are
   newly trimmed to not land on top of an object. However this may make
   the column too small to be stable.
2) Support enforcers newly take precedence over "supports on build plate only"
   and over "don't support bridges".
3) Some refactoring of the support generator code for clarity: Reduced
   some of the worst spagetti offenders.

Fixes Support generated even if support on build only activated #915
Fixes Bug: supports on build plate only #1340
Fixes Bottom interface layer is not generated , support on build plate only. (long open defect) #4199
Fixes option "supports on build plate only" does not work #3980

Fixes No support interface layers generated #1997
Fixes Feature Request: Option to combine results of 'support from build plate only' and 'support enforcers only' #2801
Fixes Support interface isn't generated: build plate only + blocked by model + support enforcer #3831
Fixes Support Enforcer don't create interface layers #5748
Fixes Support Enforcers Don't Have Top Loops/Raft #1870
Fixes Don't cancel support enforcers with "don't support bridges" #5105
@bubnikv
Copy link
Collaborator

bubnikv commented Mar 19, 2021

Fixed with 9f09f03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants