Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scan): Remove ._findings #6667

Merged

Conversation

jfagoagas
Copy link
Member

Description

Remove Scan._findings since it is not being used and only increases memory usage.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested review from a team as code owners January 23, 2025 12:09
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (80fe048) to head (e770575).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6667      +/-   ##
==========================================
- Coverage   89.37%   89.37%   -0.01%     
==========================================
  Files        1182     1182              
  Lines       33817    33815       -2     
==========================================
- Hits        30225    30222       -3     
- Misses       3592     3593       +1     
Flag Coverage Δ
prowler 89.37% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.37% <ø> (-0.01%) ⬇️
api ∅ <ø> (∅)

@jfagoagas jfagoagas requested a review from vicferpoy January 23, 2025 14:10
@jfagoagas jfagoagas merged commit ad189b3 into master Jan 23, 2025
11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-6089-remove-scan-findings-to-reduce-memory-usage branch January 23, 2025 14:58
jfagoagas added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants