chore(scan): Remove ._findings (#6667)

prowler-cloud · Jan 23, 2025 · ad189b3 · ad189b3
1 parent 7d2989a
commit ad189b3
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/prowler/lib/scan/scan.py b/prowler/lib/scan/scan.py
@@ -36,7 +36,6 @@ class Scan:
     _service_checks_to_execute: dict[str, set[str]]
     _service_checks_completed: dict[str, set[str]]
     _progress: float = 0.0
-    _findings: list = []
     _duration: int = 0
     _status: list[str] = None
 
@@ -216,10 +215,6 @@ def progress(self) -> float:
     def duration(self) -> int:
         return self._duration
 
-    @property
-    def findings(self) -> list:
-        return self._findings
-
     def scan(
         self,
         custom_checks_metadata: dict = {},
@@ -282,9 +277,6 @@ def scan(
                             if finding.status not in self._status:
                                 check_findings.remove(finding)
 
-                    # Store findings
-                    self._findings.extend(check_findings)
-
                     # Remove the executed check
                     self._service_checks_to_execute[service].remove(check_name)
                     if len(self._service_checks_to_execute[service]) == 0:

diff --git a/tests/lib/scan/scan_test.py b/tests/lib/scan/scan_test.py
@@ -333,7 +333,6 @@ def test_scan(
         assert scan.service_checks_completed == {
             "accessanalyzer": {"accessanalyzer_enabled"},
         }
-        assert scan.findings == mock_execute.side_effect()
         mock_logger.error.assert_not_called()
 
     def test_init_invalid_severity(