Removed CAN bus, can_bus_helper, adafruit_mcp2515 FC_Board code from repo #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd. Batt_Board will soon be removed from the repo. Hence, this allows for can_bus_helper to be removed.
Alandlt15
approved these changes
Jan 7, 2025
nateinaction
approved these changes
Jan 7, 2025
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the usage of the adafruit_mcp2515 library for the FC Board.
As seen in the issue linked below, adafruit_mcp2515 is used predominantly in the Batt_Board code. As the Batt_Board code will soon be removed from the repo, with @Mikefly123 's approval, I didn't deal with CAN aka adafruit_mcp2515 for this section.
This PR is in regard to the following issue:
#79
I ran this code on the v4c and v4b boards and experienced similar output as the main branch code