-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove can_bus From the Codebase #79
Comments
It looks though can_bus_helper is currently only being used in the Batt_Board, which will soon be removed from the repo. Since Batt_Board will be removed, there will be no calls to it. Instead of removing the can_bus from its existence in can_bus_helper.py, should I just delete can_bus_helper.py instead? |
Hey @blakejameson, yeah I think you can just go ahead and do that! |
Thank you @Mikefly123 ! ![]() Similarly, adafruit_mcp2515 is included mostly in Batt_Board and when it is included in pysquared.py as 'CAN', I removed where CAN is used. Instead of modifying the adafruit_mcp2515 regarding the can_bus, would I be able to go ahead and remove adafruit_mcp2515, as it will no longer be needed? |
Hey @blakejameson, yeah you can indeed go ahead and just remove the whole |
Why is This Change Being Made?
A CAN bus transceiver was introduced in the V1.5 PROVES Kit as a means of facilitating board to board communication between the RP2040 mounted on the battery board and the RP2040 mounted on the flight controller board. This never really panned out, with the preferred method of doing board to board communication being UART for lower power consumption and simplicity. As a result in PROVES Kit V2 we will be phasing out use of the
can_bus
.Due to recurring problems with the
can_bus
(as seen in #71) it may be more convenient at this point to toss thecan_bus
out of the code base rather than backtracking to fix it just to remove it later.What Needs to Be Done?
The
can_bus
needs to be purged from the code base. This includes mentions of it inpysquared.py
,functions.py
and libraries and helper files such asadafruit_mcp2515
andcan_bus_heplper.py
. Attached as some (but not all) examples of where this code lives in the codebase:In
pysquared.py
:In
functions.py
:The text was updated successfully, but these errors were encountered: