Use std::get where it's available #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xfxyjwf to review |
TeBoring
force-pushed
the
third-party
branch
6 times, most recently
from
1cac7b6 to
7d115ad
Compare
|
LGTM |
TeBoring
added a commit
that referenced
this pull request
Oct 9, 2015
Use std::get where it's available
|
Hi, This change moves functions like "Closure * NewCallback(..)" into the internal namespace. Is it okay to use such functions inside this "internal" namespace ? If not, is there a new recommended way to create Closures that we we can pass to the stubs generated by the protobuf compiler ? |
|
@mxmark hmm, I didn't notice that Closure/Callback is used in the generated stub code. I guess we just need to move the related code back to google::protobuf namespace... Can you help create a github issue for that? |
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Use std::get where it's available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.