Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewCallback() functions should not be in ::internal namespace #1966

Closed
mxmark opened this issue Aug 16, 2016 · 0 comments
Closed

NewCallback() functions should not be in ::internal namespace #1966

mxmark opened this issue Aug 16, 2016 · 0 comments

Comments

@mxmark
Copy link

mxmark commented Aug 16, 2016

Commit 7c14dc8 moved some externally used functions (such as "Closure* NewCallback(..)" to the google::protobuf::internal namespace (from the google::protobuf namespace). These NewCallback functions are needed in the stub code generated by the proto compiler, and it seems strange that they are in the "internal" namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants