C# wrapper types #611
Merged
C# wrapper types #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We do still generate the message types, as otherwise reflection breaks, even though it doesn't actually use those types. - JSON handling hasn't been implemented yet
| StringField = { { 11, "First" }, { 12, "Second" }, { 13, "" }, { 14, null } }, | ||
| Uint32Field = { { 15, uint.MaxValue }, { 16, uint.MinValue }, { 17, 0U } }, | ||
| Uint64Field = { { 18, ulong.MaxValue }, { 19, ulong.MinValue }, { 20, 0UL } }, | ||
| }; |
There was a problem hiding this comment.
This test doesn't test anything.
|
Done. |
|
|
||
| // Merging is odd with wrapper types, due to the way that default values aren't emitted in | ||
| // the binary stream. In fact we cheat a little bit - a message with an explicitly present default | ||
| // value will have that default value ignored. |
There was a problem hiding this comment.
Let's add a test that parses an IntWrapper from a stream that has the default value set explicitly. Comment of that test can describe that this is actually not the ideal behavior, but that's the way it's implemented now.
There was a problem hiding this comment.
Happy to do so, but will be in the morning.
There was a problem hiding this comment.
Done - and added a fairly simple oneof test too.
|
Thanks for contributing this! |
|
Thanks. Pushed the changes - waiting for CI, then will merge. |
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
C# wrapper types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for an initial review, but I wouldn't be surprised if we wanted some more changes before merging.
@jtattermusch @anandolee