-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Google.ProtocolBuffers directories and projects to Google.Protobuf #600
Comments
Which directories do you mean? I'd be happy enough to rename the directories to Possibly wait until I've "done" wrapper types, but before we merge into master? I know we want to merge into master soon, but I'd rather not have outstanding code when we rename the directories. |
Currently we don't have any pull requests against C# code, so if you don't have any pending work in your fork, it's probably a good time to do this now. Let me know if you want me to create the PR, I am happy to do so. |
I have quite a chunk of pending work on wrapper types, which is nowhere near ready to create a PR for yet :( That's all I currently have up in the air though - how about we get that done, and then I address that before anything new? Or we could just do it now and I'll clear up as best I can... |
I will leave it up to you, as you're the one affected by this the most. |
Right, now I have no more pending code, I'm on this. |
Looks like this was done |
Reference dependencies as imports in generated typescript definitions…
We have a bit of a debt here. This has no impact to fuctionality (because the resulting assembly is already named Google.Protobuf and so are the namespaces, but later this will be really hard to change, so why don't keep things clean.
@jskeet opinions?
The text was updated successfully, but these errors were encountered: