Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Google.ProtocolBuffers directories and projects to Google.Protobuf #600

Closed
jtattermusch opened this issue Jul 15, 2015 · 8 comments
Closed
Assignees
Labels

Comments

@jtattermusch
Copy link
Contributor

We have a bit of a debt here. This has no impact to fuctionality (because the resulting assembly is already named Google.Protobuf and so are the namespaces, but later this will be really hard to change, so why don't keep things clean.

@jskeet opinions?

@jtattermusch jtattermusch added this to the C# code cleanup milestone Jul 15, 2015
@jskeet
Copy link
Contributor

jskeet commented Jul 15, 2015

Which directories do you mean? src/ProtocolBuffers and src/ProtocolBuffers.Test? If so, I'd been thinking the same thing.

I'd be happy enough to rename the directories to Google.Protobuf and Google.Protobuf.Tests.

Possibly wait until I've "done" wrapper types, but before we merge into master? I know we want to merge into master soon, but I'd rather not have outstanding code when we rename the directories.

@jtattermusch
Copy link
Contributor Author

Currently we don't have any pull requests against C# code, so if you don't have any pending work in your fork, it's probably a good time to do this now. Let me know if you want me to create the PR, I am happy to do so.

@jskeet
Copy link
Contributor

jskeet commented Jul 15, 2015

I have quite a chunk of pending work on wrapper types, which is nowhere near ready to create a PR for yet :(

That's all I currently have up in the air though - how about we get that done, and then I address that before anything new? Or we could just do it now and I'll clear up as best I can...

@jtattermusch
Copy link
Contributor Author

I will leave it up to you, as you're the one affected by this the most.

@jtattermusch jtattermusch changed the title Move rename Google.ProtocolBuffers directories and projects to Google.Protobuf Rename Google.ProtocolBuffers directories and projects to Google.Protobuf Jul 16, 2015
@jtattermusch
Copy link
Contributor Author

@jskeet, do you have any other in-progress code besides #611?

It looks like after some of my PR get merged (hopefully today), this would be the last thing blocking merging csharp-experimental to master.

@jskeet
Copy link
Contributor

jskeet commented Jul 16, 2015

No, #611 is it for now. If we can get that in - even if more work is required - that would be a great time to do the rename.

We should also look at addressbook.proto before merging though - I suspect I've broken the Java and C++ code there. See #565

@jskeet jskeet self-assigned this Jul 17, 2015
@jskeet
Copy link
Contributor

jskeet commented Jul 17, 2015

Right, now I have no more pending code, I'm on this.

@jtattermusch
Copy link
Contributor Author

Looks like this was done

taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
Reference dependencies as imports in generated typescript definitions…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants