Update commit id in Dockerfile to trigger update. #2467
Conversation
| @@ -132,7 +132,7 @@ ENV MVN mvn --batch-mode | |||
| RUN cd /tmp && \ | |||
| git clone https://github.com/google/protobuf.git && \ | |||
| cd protobuf && \ | |||
| git reset bf379715c93b581eeb078cec1f0dd8a7d79df431 && \ | |||
| git reset 46ae90dc5e145b12fffa7e053a908a9f3e066286 && \ | |||
There was a problem hiding this comment.
You don't need to change this commit id if Java dependencies are not changed.
There was a problem hiding this comment.
#2435 changed php's dependency.
There was a problem hiding this comment.
This line is building the cache for Java. If you haven't changed any Java dependencies, you don't need to change this line.
There was a problem hiding this comment.
This line is actually shared by both java and php. php also needs to download github repository.
There was a problem hiding this comment.
Could you instead add a "git reset ..." on the line that builds php dependencies? That would be much clearer than changing it here.
|
The failed test is for ruby, which is not related to this PR. |
TeBoring
force-pushed
the
master
branch
4 times, most recently
from
ab6bd26 to
0692e50
Compare
| @@ -473,7 +473,9 @@ def test_map_basic | |||
| m2 = m.dup | |||
| assert_equal m, m2 | |||
| assert m.hash != 0 | |||
| assert_equal m.hash, m2.hash | |||
| # TODO(teboring): Disable jruby test temperarily for it randomly fails. | |||
There was a problem hiding this comment.
This test case is ran under both regular ruby and jruby. You are disabling both here. Could you just ignore the jruby test?
No description provided.