Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make php generated code conform to PSR-4. #2435

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Make php generated code conform to PSR-4. #2435

merged 1 commit into from
Dec 8, 2016

Conversation

TeBoring
Copy link
Contributor

@TeBoring TeBoring commented Dec 2, 2016

  1. Generate single file for each message.
  2. Lazily initiate metadata.
    Fixes [php] Allow individual files per class #2267

@TeBoring TeBoring force-pushed the master branch 2 times, most recently from 80cd21b to 3f445a3 Compare December 5, 2016 18:50
@TeBoring
Copy link
Contributor Author

TeBoring commented Dec 5, 2016

@stanley-cheung
This PR depends on newly added php/composer.json. The broken jenkins test needs to wait for this PR being merged, so it can see the newly added php/composer.json during the setup phase.

@TeBoring TeBoring force-pushed the master branch 2 times, most recently from 751891b to a21881a Compare December 6, 2016 22:30
@TeBoring
Make php generated code conform to PSR-4.
7f1e951 
1. Generate single file for each message.
2. Lazily initiate metadata.
@TeBoring TeBoring mentioned this pull request Dec 7, 2016
Closed
stanley-cheung
stanley-cheung reviewed Dec 7, 2016
View reviewed changes
php/composer.json
"autoload": {
"psr-4": {
"Foo\\": "tests/generated/Foo",
"Bar\\": "tests/generated/Bar",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool

stanley-cheung
stanley-cheung approved these changes Dec 7, 2016
View reviewed changes
Copy link
Contributor

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TeBoring
Copy link
Contributor Author

TeBoring commented Dec 8, 2016

Thanks!

@TeBoring TeBoring merged commit 46ae90d into protocolbuffers:master Dec 8, 2016
@TeBoring TeBoring mentioned this pull request Dec 8, 2016
Merged
@stanley-cheung stanley-cheung mentioned this pull request Jan 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeBoring @stanley-cheung @googlebot