Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for TensorFlow compilation and running problems #1500

Closed
wants to merge 1 commit into from

Conversation

petewarden
Copy link
Contributor

These are the changes I've found necessary to successfully build and run the top-of-tree protobuf with TensorFlow. I don't understand the intricacies of the Python importing changes, those fixes come from empirically trying different import paths until I found one that worked!

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@davidzchen
Copy link
Contributor

I think the changes to add std:: to the using statements are needed, but the imports attribute of Bazel's Python rules should cover adding the right directory to the PYTHONPATH, and the changes to the Python imports here are not necessary.

I have verified that all tests are passing when running baze test //tensorflow/python/... with my patch to replace the vendored protobuf tree in TensorFlow with a workspace dependency in tensorflow/tensorflow#1289.

However, if you happen to have protobuf installed on your local system and are getting Python build errors, most likely, you are running into bazelbuild/bazel#1209.

@davidzchen
Copy link
Contributor

FYI I have opened #1586 for the Python fixes.

@TeBoring TeBoring self-assigned this Jun 8, 2018
@TeBoring TeBoring closed this Jun 8, 2018
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants