Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on Windows using vs2013 #885

Closed
afarbos opened this issue Oct 15, 2015 · 1 comment
Closed

Build on Windows using vs2013 #885

afarbos opened this issue Oct 15, 2015 · 1 comment

Comments

@afarbos
Copy link

afarbos commented Oct 15, 2015

I am currently trying to compile protobuf v2.4.1. I suceeded to convert the sln, but when I try to compile i have many errors.

I succeed to solve most of them, but I still have one weird error: 'min' : identifier not found or 'max' : identifier not found. Do you know how to nicely solve that issue ? (I already try to add "/D NOMINMAX")
@afarbos
Copy link
Author

afarbos commented Oct 23, 2015

The problem was the fact that the upgrade solution use MachineX86 instead of MachineX64. I did not found any nice windows solution to do that. So, my current solution is using sed on the vcxproj to replace this value.

@afarbos afarbos closed this as completed Oct 23, 2015
adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
@vicb @bcoe
fix!: encoding of empty Buffers (protocolbuffers#1514)
b4cae07 
closes protocolbuffers#1500
fixes protocolbuffers#885

Co-authored-by: Benjamin E. Coe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afarbos