Skip to content

Commit

Permalink
Revert "Remove unused f expression from jscode gen. (#5573)"
Browse files Browse the repository at this point in the history
The removed variable here is actually used breaking downstream bazel
builds.
  • Loading branch information
dankurka authored and acozzette committed Mar 21, 2019
1 parent e6779e9 commit e2461b5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/google/protobuf/compiler/js/js_generator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2272,7 +2272,7 @@ void Generator::GenerateClassToObject(const GeneratorOptions& options,
" * @suppress {unusedLocalVariables} f is only used for nested messages\n"
" */\n"
"$classname$.toObject = function(includeInstance, msg) {\n"
" var obj = {",
" var f, obj = {",
"classname", GetMessagePath(options, desc));

bool first = true;
Expand Down

1 comment on commit e2461b5

@samccone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this breaking downstream bazel builds?
Can someone post steps to reproduce the break?

Please sign in to comment.