Remove unused f expression from jscode gen. #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varadic assignment in javascript where the right hand expression is an
object yields a single set assignment with the right most lefthand variable,
while leaving the other left side expressions undefined.
For example:
var a,b = {}
will only initialize a to undefined. But will set b to the {} value.
--
For this code since f is never used, it is a safe operation to remove
it.
TeBoring
approved these changes
Jan 14, 2019
dankurka
added a commit
to dankurka/protobuf
that referenced
this pull request
Mar 21, 2019
…5573)" The removed variable here is actually used breaking downstream bazel builds.
acozzette
pushed a commit
that referenced
this pull request
Mar 21, 2019
The removed variable here is actually used breaking downstream bazel builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variadic assignment in javascript where the right hand expression is an
object yields a single set assignment with the right most lefthand variable,
while leaving the other left side expressions undefined.
For example:
var a,b = {}
will only initialize a to undefined. But will set b to the {} value.
--
For this code since f is never used, it is a safe operation to remove
it.