Use preferred protocol first when resolving hostname #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, LookupIPAddr() is used to do the DNS query, which sends two DNS queries for A/AAAA records, even if the config has preferred protocol set to ip4 and does not allow fallback protocol. This change will change to use LookupIP() with the preferred protocol, and only try fallback protocol if it's set to true. In most cases doing this will save one RTT of DNS query. Signed-off-by: Yuchen Ying <[email protected]>
brian-brazil
reviewed
Jan 4, 2021
Signed-off-by: Yuchen Ying <[email protected]>
Signed-off-by: Yuchen Ying <[email protected]>
Signed-off-by: Yuchen Ying <[email protected]>
Signed-off-by: Yuchen Ying <[email protected]>
|
Thanks! |
|
I wonder if a new version can cut with this PR included? Or alternatively can you publish a nightly docker image? |
|
Does the docker image at prom/blackbox-exporter:master include this merge? |
|
@crockk It should be even though I'm actually using the master tag image and I see no change in the behavior. Either way this PR will be on 0.19 which for the looks of it it's just around the corner. |
roidelapluie
added a commit
to roidelapluie/blackbox_exporter
that referenced
this pull request
May 28, 2021
…eus#728)" This reverts commit 847b668. Signed-off-by: Julien Pivotto <[email protected]>
|
Also related to golang/go#45024, need wait golang 1.17 release and upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, LookupIPAddr() is used to do the DNS query,
which sends two DNS queries for A/AAAA records, even if the config has
preferred protocol set to ip4 and does not allow fallback protocol.
This change will change to use LookupIP() with the preferred protocol,
and only try fallback protocol if it's set to true. In most cases doing
this will save one RTT of DNS query.
Fixes #724