prometheus-adapter: add nodes resource to aggregated-metrics-reader #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
Jan 22, 2020
| @@ -191,7 +191,7 @@ local k = import 'ksonnet/ksonnet.beta.4/k.libsonnet'; | |||
| local rules = | |||
| policyRule.new() + | |||
| policyRule.withApiGroups(['metrics.k8s.io']) + | |||
| policyRule.withResources(['pods']) + | |||
| policyRule.withResources(['pods', 'nodes']) + | |||
There was a problem hiding this comment.
didn't this also need aggregate-to-cluster-reader or is that an openshift thing?
There was a problem hiding this comment.
That is indeed an openshift thing, we need to augment that aggregation in CMO (after merging and pulling this in).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively backports kubernetes-sigs/metrics-server#297 here. We also need it to fix https://bugzilla.redhat.com/show_bug.cgi?id=1723662.