metrics_server: add nodes resource to aggregated-metrics-reader

[s-urbaniak]

related with prometheus-operator/kube-prometheus#384 and kubernetes-sigs/metrics-server#297
/cc @openshift/openshift-team-monitoring

[openshift-ci-robot]

@s-urbaniak: This pull request references Bugzilla bug 1793628, which is invalid:

• expected dependent Bugzilla bug 1723662 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1793628: metrics_server: add nodes resource to aggregated-metrics-reader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[brancz]

/lgtm

[s-urbaniak]

/test gcp-major-upgrade

[brancz]

/retest

[brancz]

/retest

[openshift-ci-robot]

@s-urbaniak: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/gcp-major-upgrade	4fe8d50	link	/test gcp-major-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdodson]

/override ci/prow/gcp-major-upgrade

[openshift-ci-robot]

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/gcp-major-upgrade

In response to this:

/override ci/prow/gcp-major-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[brancz]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• roles/metrics_server/OWNERS [brancz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[simonpasquier]

@s-urbaniak you need to edit the PR description to remove "Bug ....:" 😏

[lilic]

/retitle metrics_server: add nodes resource to aggregated-metrics-reader

[openshift-ci-robot]

@s-urbaniak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

metrics_server: add nodes resource to aggregated-metrics-reader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[brancz]

I think linking the bugzilla is correct, but the 3.11 bug does should not be linked to the 4.x bug I think.

[brancz]

I guess that was good enough after all 🤷‍♂️ 😄 🎉

[sdodson]

I guess that was good enough after all man_shrugging smile tada

but now you have to manually go set the bug MODIFIED, if the 4.4 bug had been VERIFIED this should have been normal process.

[brancz]

Makes sense. Thanks for the reminder!