[kube-prometheus-stack] prometheus-operator0.59.1/Prometheus2.38.0/all dependencies

[Allex1]

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• Bumps the kube-state-metrics dependency version to latest

Special notes for your reviewer

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

[monotek]

this should be a breaking changhe as the default labels are changed in the subchart.
please add update instructions to readme.

[Allex1]

this should be a breaking changhe as the default labels are changed in the subchart.
please add update instructions to readme.

@monotek I'm assuming you're referring to #927

[Allex1]

@mrueg @monotek because 40.0.0 is such a round number I've updated prom-op and prom as well.

[monotek]

the crds, dashboards and rules are not upgraded (see scripts in hack directory).

the readme should have upgrade instructions for the labels, not just a note that it will break.

edit: sorry, i had node exporter in mind: #2212

please update it too. upgrade instructions can be used from its readme: https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-node-exporter#3x-to-4x

please test the update at least once. the release lable might be needed to set now for node exporter.

[mrueg]

values.yaml needs the prometheus-operator and config-reloader tags updated to v0.59.1 as well

[mrueg]

Thanos can be updated to https://github.com/thanos-io/thanos/releases/tag/v0.28.0 as well

[Allex1]

@monotek @mrueg seems this needs some more work/testing.
Before we finish this can you guys pls have a look at #2430 and #2429
To me it would make sense to merge them first.

[monotek]

@monotek @mrueg seems this needs some more work/testing. Before we finish this can you guys pls have a look at #2430 and #2429 To me it would make sense to merge them first.

the mentioned prs are added.

i've created #2453 to be able to use "releaseLabel: true" in node-exporter to get the needed labels added.

[monotek]

i've added some changes to the readme, updated some more image tags, removed some unneeded comments, updated node exporter to 4.2.0 and added the release label to the values. please check if update works as described.

[Allex1]

@monotek I hope to find some time and test the upgrade in the following days.

[monotek]

update in a kind cluster from 39.0.0 worked for me.
had to use --force-conflicts on some crds though.

@mrueg
do you see any issues?

[Allex1]

update in a kind cluster from 39.0.0 worked for me. had to use --force-conflicts on some crds though.

@mrueg do you see any issues?

Tested as well in kind and confirmed it's working fine. Should we add the --force-conflicts flag in the upgrade docs ?

[monotek]

update in a kind cluster from 39.0.0 worked for me. had to use --force-conflicts on some crds though.
@mrueg do you see any issues?

Tested as well in kind and confirmed it's working fine. Should we add the --force-conflicts flag in the upgrade docs ?

Not sure. Maybe it's unwanted to overwrite directly. Problem should have existed before and we don't added it too.

[totoroot]

i've added some changes to the readme, updated some more image tags, removed some unneeded comments, updated node exporter to 4.2.0 and added the release label to the values. please check if update works as described.

@monotek With your changes added to this PR you basically just removed comments which were added with PR #2411, because you deemed them to be not useful although @moroviintaas and @Xtigyro disagreed.

The chart's values.yaml has over 3000 LOC and I agree that this might not be ideal, but removing comments other consider helpful isn't the way to go IMO. I'd personally wish for changes like that to be done more transparently.