[kube-prometheus-stack] Hinting containers' image source values for offline deployment

[moroviintaas]

[kube-prometheus-stack]

• Hint for replacing image sources for containers:
  • grafana
  • sidecar
  • kube-state-metrics
  • prometheus-node-exporter

Signed-off-by: moroviintaas [email protected]

[kube-prometheus-stack]

• Bump chart version

Signed-off-by: moroviintaas [email protected]

What this PR does / why we need it

I was deploying kube-prometheus-stack on offline environment with internal image registry. I have created own values.yml file with changed image sources pointing to my registry. Yet some images failed to be pulled, as they had been defined in dependency charts. Maybe it is worth to note that default grafana image tag (in dependency chart) is currently set to "", which should resolve to "latest" as far as I know and potentially lead to stability issue.

This PR does not change chart behavior, only adds comment hints on where I had to insert my registry paths in kube-prometheus-stack values.yml file in order to set up containers. It may save some time of digging for other offline deployers.

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

[Xtigyro]

Thanks for the contribution, @moroviintaas! 🥇

Could you please bump the minor (and not the bugfix) chart version in Chart.yaml?

[monotek]

I don't think that's needed as the defaults are used anyway. Values file is already big enough.

[Xtigyro]

I don't think that's needed as the defaults are used anyway. Values file is already big enough.

@monotek We do that for other components too. I think it's a good practice.

[moroviintaas]

Thanks for the contribution, @moroviintaas! 🥇

Could you please bump the minor (and not the bugfix) chart version in Chart.yaml?

Done in replace commit 9ceee96

[moroviintaas]

I don't think that's needed as the defaults are used anyway. Values file is already big enough.

In most cases it works well, however when I needed to change image sources (offline deployment), I firstly changed only these visible in this file and deployment failed. Components prometheus-node-exporter and kube-state-metrics are managed in this very repository so in online it is ok. However sidecar's and grafana's image is defaulted in external repository grafana/helm-charts, with sidecar tagged properly and grafana not tagged (resolving to latest). However I am new to Kubernetes and Helm so I might be wrong.

EDIT 1: Edted grafana repository link;

If needed - we can revert the changes.

[monotek]

@Xtigyro imho Bugfix version would have been right, as no new features have been added.