fix: wrong snmp_exporter binary source path

[sebbbastien]

This is a PR to fix #96

Not familiar with contributions and PR, please be indulgent

[SuperQ]

Hmm, I think there's more to fix than this.

[sebbbastien]

Hmm, I think there's more to fix than this.

Do you mean, this error is present on other installations, or, there is more to fix for snmp_exporter install?

To fix the error during snmp_exporter install, the change is enough on my side.

Is it possible to write a molecule test to check this issue?

[gardar]

The problem is actually just that the dest from get_url is missing the trailing slash, which makes ansible use a random name rather than the name from the source.

ansible/roles/snmp_exporter/tasks/install.yml

Lines 2 to 9 in 26d2f99

	- name: Download snmp_exporter binary to local folder
	become: false
	ansible.builtin.get_url:
	url: "{{ snmp_exporter_binary_url }}"
	dest: "/tmp"
	checksum: "sha256:{{ snmp_exporter_checksum }}"
	mode: 0644
	register: _download_binary

Should be either

  ansible.builtin.get_url:
    url: "{{ snmp_exporter_binary_url }}"
-    dest: "/tmp"
+    dest: "/tmp/"
    checksum: "sha256:{{ snmp_exporter_checksum }}"
    mode: 0644
  register: _download_binary

or to be consistent with the other roles:

  ansible.builtin.get_url:
    url: "{{ snmp_exporter_binary_url }}"
-    dest: "/tmp"
+    dest: "/tmp/snmp_exporter-{{ snmp_exporter_version }}.linux-{{ go_arch_map[ansible_architecture] | default(ansible_architecture) }}.tar.gz"
    checksum: "sha256:{{ snmp_exporter_checksum }}"
    mode: 0644
  register: _download_binary

[SuperQ]

This should be fixed by #204.

[SuperQ]

Fixed in #204

[github-actions]

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.