Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make binary installs consistent #204

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Aug 22, 2023

Update the blackbox_exporter and snmp_exporter installs to be consistent with other exporter package installs.

Fixes: #96

@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from 8af4a0f to 62ca42e Compare August 22, 2023 17:07
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 22, 2023
@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from 62ca42e to 172f555 Compare August 22, 2023 17:08
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 22, 2023
@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from 172f555 to 3a1a4a8 Compare August 22, 2023 17:10
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from 3a1a4a8 to 343ab98 Compare August 22, 2023 18:12
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 22, 2023
@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from 343ab98 to fb941fa Compare August 22, 2023 18:40
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 22, 2023
@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from fb941fa to e89cb50 Compare August 22, 2023 18:54
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 22, 2023
@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from e89cb50 to 9f2d2c5 Compare August 22, 2023 18:55
@github-actions github-actions bot removed the bugfix label Aug 22, 2023
@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from 9f2d2c5 to 76fc3f6 Compare August 22, 2023 19:08
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 22, 2023
@SuperQ SuperQ requested a review from gardar August 22, 2023 19:25
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 22, 2023
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only thing missing is a molecule scenario for latest version of snmp_exporter

Update the blackbox_exporter and snmp_exporter installs to be consistent
with other exporter package installs.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/consistent_download_dests branch from 76fc3f6 to 2d940e0 Compare August 25, 2023 06:35
@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 25, 2023

Whups, I forgot to push that change.

@github-actions github-actions bot added bugfix and removed bugfix labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install snmp_node_exporter
2 participants