-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add test for argument_specs matching #177
Conversation
1127aad
to
1de15b3
Compare
1de15b3
to
32bc653
Compare
32bc653
to
a37d8ea
Compare
a37d8ea
to
e7e937c
Compare
27c93bb
to
6494baa
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #177 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 102
Branches ? 8
========================================
Hits ? 102
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
6494baa
to
15ee3fd
Compare
Compare contents of `meta/arguments_spec.yml` against `defaults/main.yml` on each role to make sure keys match. Signed-off-by: SuperQ <[email protected]>
Signed-off-by: SuperQ <[email protected]>
15ee3fd
to
5c8fe60
Compare
Nice! Perhaps we should take it a step further and generate the defaults from the argument_specs automatically? |
Possibly, we would need to have a way to include example content as comments. |
We just need to move the example content into the descriptions of the argument specs, we could then just take the argument spec descriptions and convert those into comments in the defaults. |
Compare contents of
meta/arguments_spec.yml
againstdefaults/main.yml
on each role to make sure keys match.