Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read defaults from meta/argument_specs.yml #77664

Closed
1 task done
nkakouros opened this issue Apr 27, 2022 · 5 comments
Closed
1 task done

Read defaults from meta/argument_specs.yml #77664

nkakouros opened this issue Apr 27, 2022 · 5 comments
Labels
affects_2.14 feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. waiting_on_contributor This would be accepted but there are no plans to actively work on it.

Comments

@nkakouros
Copy link
Contributor

Summary

Defaults are defined in defaults/main.yml. But, the meta/argument_specs.yml file also supports defining the default value of variables. Maintaining both is just duplicating code. A role author could keep defaults only in defaults/main.yml but that would require the users to look at two files to find out about variable documentation.

It would be great if meta/argument_specs.yml was also consulted for default values of variables. To avoid conflicts with defaults/main.yml, the latter could take precedence.

Issue Type

Feature Idea

Component Name

argument_specs

Additional Information

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibot
Copy link
Contributor

ansibot commented Apr 27, 2022

Files identified in the description:
None

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.14 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 27, 2022
@mattclay mattclay added waiting_on_contributor This would be accepted but there are no plans to actively work on it. and removed needs_triage Needs a first human triage before being processed. labels Apr 28, 2022
@nkakouros
Copy link
Contributor Author

@mattclay What are you waiting for from me?

@mattclay
Copy link
Member

mattclay commented Sep 6, 2022

@nkakouros The waiting_on_contributor label is documented as follows:

The feature or fix would be accepted, but there are no plans to actively work on it.

If you'd like to work on this feature, I recommend starting a discussion on it first.

@s-hertel
Copy link
Contributor

@nkakouros If you add an item to the meeting agenda, please mention what needs to be resolved or attend to have a conversation. If you wanted core to reconsider the priority you would need to advocate for it.

This was discussed when the initial feature was designed and it was decided against because it adds a lot of complexity. We're open to accepting a good implementation, so this is waiting on anyone in the community, not specifically you. Since it's a tricky one, starting a discussion as suggested above or creating a proposal would probably be the best way to start.

@nkakouros
Copy link
Contributor Author

I meant to attend the meeting but just couldn't.

I bypassed the issue by adding a script in my roles and running it in CI after each commit. I will close this as I don't plan to work on this and there is a solution, although it would be nice to be baked in.

@ansible ansible locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.14 feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. waiting_on_contributor This would be accepted but there are no plans to actively work on it.
Projects
None yet
Development

No branches or pull requests

4 participants