Events notification system for Nessie - VersionStore changes #6647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2023
snazy
reviewed
Apr 21, 2023
There was a problem hiding this comment.
Not a full review (and not done yet), but went though a bunch of files.
Adding all the *Result objects to the VersionStore functions is fine.
Not so much a fan of the new "top-leve" LazyPut (commented).
I suspect, with some of the suggestions applied, the size of the PR will reduce a bit.
versioned/spi/src/main/java/org/projectnessie/versioned/LazyPut.java
Outdated
Show resolved
Hide resolved
versioned/spi/src/main/java/org/projectnessie/versioned/CommitResult.java
Show resolved
Hide resolved
versioned/spi/src/main/java/org/projectnessie/versioned/VersionStore.java
Outdated
Show resolved
Hide resolved
...e/store/src/main/java/org/projectnessie/versioned/storage/versionstore/BaseCommitHelper.java
Outdated
Show resolved
Hide resolved
...age/store/src/main/java/org/projectnessie/versioned/storage/versionstore/ContentMapping.java
Outdated
Show resolved
Hide resolved
...storage/store/src/main/java/org/projectnessie/versioned/storage/versionstore/CommitImpl.java
Show resolved
Hide resolved
adutra
force-pushed
the
events-versionstore-standalone
branch
from
08198cf to
1b05976
Compare
adutra
force-pushed
the
events-versionstore-standalone
branch
from
62ba23e to
479615d
Compare
snazy
reviewed
Apr 26, 2023
...ioned/persist/tx/src/main/java/org/projectnessie/versioned/persist/tx/TxDatabaseAdapter.java
Outdated
Show resolved
Hide resolved
...mon/src/test/java/org/projectnessie/versioned/storage/common/logic/TestIndexesLogicImpl.java
Outdated
Show resolved
Hide resolved
...age/store/src/main/java/org/projectnessie/versioned/storage/versionstore/ContentMapping.java
Outdated
Show resolved
Hide resolved
versioned/spi/src/main/java/org/projectnessie/versioned/Put.java
Outdated
Show resolved
Hide resolved
adutra
force-pushed
the
events-versionstore-standalone
branch
4 times, most recently
from
941b648 to
ba74459
Compare
adutra
commented
May 3, 2023
versioned/tests/src/main/java/org/projectnessie/versioned/tests/AbstractMerge.java
Outdated
Show resolved
Hide resolved
adutra
commented
May 3, 2023
versioned/tests/src/main/java/org/projectnessie/versioned/tests/AbstractTransplant.java
Outdated
Show resolved
Hide resolved
adutra
force-pushed
the
events-versionstore-standalone
branch
3 times, most recently
from
03ef247 to
8336765
Compare
adutra
force-pushed
the
events-versionstore-standalone
branch
from
8336765 to
12300f1
Compare
snazy
reviewed
May 5, 2023
...r/src/main/java/org/projectnessie/versioned/persist/adapter/spi/AbstractDatabaseAdapter.java
Outdated
Show resolved
Hide resolved
| break; | ||
| default: | ||
| throw new UnsupportedOperationException("Unknown opVariant " + opVariant); | ||
| } | ||
|
|
||
| if (!casSuccess) { | ||
| if (opVariant == CasOpVariant.COMMIT) { | ||
| if (opVariant == CasOpVariant.COMMIT || opVariant == CasOpVariant.MERGE) { | ||
| cleanUpCommitCas(ctx, individualCommits, individualKeyLists); |
There was a problem hiding this comment.
Just noting (nothing to change here) - only for posterity why this is not in the new model:
Initially I ported this behavior to the new storage model as well, but (manual, bad "heavy load") tests proved that this can go sideways - up to the point that two concurrent writers produce the exact same commit, one wins and bumps HEAD, the other one "loses" and deletes the commit -> HEAD points to a non-existing commit. It's a rather artificial and will probably never happen in real-live, but still, there's a chance.
versioned/spi/src/main/java/org/projectnessie/versioned/EventsVersionStore.java
Outdated
Show resolved
Hide resolved
versioned/spi/src/main/java/org/projectnessie/versioned/MergeResult.java
Outdated
Show resolved
Hide resolved
versioned/tests/src/main/java/org/projectnessie/versioned/tests/AbstractReferences.java
Outdated
Show resolved
Hide resolved
versioned/tests/src/main/java/org/projectnessie/versioned/tests/AbstractAssign.java
Show resolved
Hide resolved
versioned/tests/src/main/java/org/projectnessie/versioned/tests/AbstractCommits.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of PRs related to the events notification system for Nessie.
See design doc: https://github.com/projectnessie/nessie/blob/main/design/events.md.
This PR focuses on changes required to the existing
VersionStoreAPI and implementations.Summary of changes:
EventsVersionStoreimplementation following the delegate pattern already used for metrics and tracing. Not used for now.VersionStorenow return more detailed results:commit()returnsCommitResultassign()returnsReferenceAssignedResultcreate()returnsReferenceCreatedResultdelete()returnsReferenceDeletedResultMergeResultnow has more methods:BranchName getSourceBranch();List<COMMIT> getAddedCommits();this is the most tricky additionLazyPutinterface: contrary toPut, it does not deserialize the content value until it's necessary to do so. (The goal is to avoid deserializing contents on Nessie's write path, if the REST API doesn't need it.)All these additions are meant to be consumed by the events system, not by the REST API which does not change at all, as required by the design doc.