Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CommitImpl#contentIdFromContent to pre-load contents #6673

Closed
adutra opened this issue Apr 24, 2023 · 1 comment
Closed

Refactor CommitImpl#contentIdFromContent to pre-load contents #6673

adutra opened this issue Apr 24, 2023 · 1 comment

Comments

@adutra
Copy link
Contributor

adutra commented Apr 24, 2023

See #6647 (comment) for context.

Refactor org.projectnessie.versioned.storage.versionstore.CommitImpl#contentIdFromContent to pre-load these contents, so they are bulk-loaded and in turn available via the cache.
@adutra adutra mentioned this issue Apr 24, 2023
Merged
@snazy
Copy link
Member

snazy commented Oct 13, 2023

Looked a bit more into this, and I thing that the probability of that function being called is effectively 0, so it is not worth the effort.

@snazy snazy closed this as completed Oct 13, 2023
snazy added a commit to snazy/nessie that referenced this issue Oct 13, 2023
@snazy
Nit: replace TODO with comment
ce9d1b7 
See projectnessie#6673
@snazy snazy mentioned this issue Oct 13, 2023
Merged
snazy added a commit that referenced this issue Oct 13, 2023
@snazy
Nit: replace TODO with comment (#7624)
6efcf01 
See #6673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adutra @snazy