Extra deployment object when processing ZIP and WAR deployments

[JasonFreeberg]

When deploying with GitHub Actions (uses /zipdeploy and /wardeploy) an extra deployment object is created in the /deployments list. This clutters the deployments list, and the deployment logs are stored in this extra object, not in the deployment object from GitHub Actions, so it's hard for users to find the right logs.

• It looks like the message is added to every push deployment handler:

  kudu/Kudu.Services/Deployment/PushDeploymentController.cs

  Line 34 in 1382420

  private const string DefaultMessage = "Created via a push deployment";

• This method adds the deployment to the deployments API:

  kudu/Kudu.Core/Deployment/ArtifactDeploymentInfo.cs

  Line 8 in 1382420

  public class ArtifactDeploymentInfo : DeploymentInfoBase

Duplicate entries in Kudu

... which creates duplicates in the deployment center

[ehamai]

Just a little more context. Since the extra deployment object isn't tied to a real commit id, this affects the portal experience because it means that we're not able to group all the logs from GitHub Actions to Zip Deploy based on commit id.

@suwatch do you know who we should talk to about this by chance?

[suwatch]

There were 2 calls making to KUDU from Github action – both instructed Kudu to create deployment entry (one being ZipDeploy and another to create deployment entry). I would follow up to the team owning github action task on DevOps.

[JasonFreeberg]

Thanks Suwat! I'll follow up with them. Best, Jason

…

On Sun, Feb 14, 2021, 1:39 PM Suwat Ch ***@***.***> wrote: There were 2 calls making to KUDU from Github action – both instructed Kudu to create deployment entry (one being ZipDeploy and another to create deployment entry). I would follow up to the team owning github action task on DevOps. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3268 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEPBC6HXSNEGUH4MNPNYOYDS7A7HPANCNFSM4XDRMYXA> .

[suwatch]

Wonderful. Will close this for now.