Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate deployment entries in the Portal #110

Closed
JasonFreeberg opened this issue Feb 24, 2021 · 9 comments
Closed

Duplicate deployment entries in the Portal #110

JasonFreeberg opened this issue Feb 24, 2021 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@JasonFreeberg
Copy link
Contributor

JasonFreeberg commented Feb 24, 2021

projectkudu/kudu#3268

When deploying with this action an extra deployment object is created in the /deployments list. This clutters the deployments list, and the deployment logs are stored in this extra object, not in the deployment object from GitHub Actions, so it's hard for users to find the right logs. The expected behavior is to have one deployment object with a commit ID that matches the one in GitHub, and that all the logs are in that object.

Duplicate entries in Kudu

image

... which creates duplicates in the deployment center

image

@AmrutaKawade
Copy link
Contributor

We use kudu zip deploy api for deploying app, which creates first entry in deployments with message Created via a push deployment

after this deployment we again update status of deployment here with additional details

await deploymentProvider.UpdateDeploymentStatus(isDeploymentSuccess);

which is creating another entry in deployment.

I have fixed this issue by adding additional details while calling zipdeploy itself microsoft/pipelines-appservice-lib#34

and then removing updatestatus call #111

@JasonFreeberg
Copy link
Contributor Author

Wow, quick turnaround @AmrutaKawade! Just want to confirm, will the deployment object be tagged with the git commit ID?

CC @nertim @spellegrino021

@AmrutaKawade
Copy link
Contributor

First entry of log will be as is, instead of Created via a push deployment message will be json object with sha of commit ID
and second entry will removed

@spellegrino021
Copy link
Collaborator

spellegrino021 commented Feb 26, 2021

First entry of log will be as is, instead of Created via a push deployment message will be json object with sha of commit ID
and second entry will removed

Hi @AmrutaKawade would it be possible for this message to be the corresponding commit message in GitHub? It might make a little more sense to people to have that information rather than the JSON object. Thanks!

@AmrutaKawade
Copy link
Contributor

AmrutaKawade commented Mar 3, 2021

First entry of log will be as is, instead of Created via a push deployment message will be json object with sha of commit ID
and second entry will removed

Hi @AmrutaKawade would it be possible for this message to be the corresponding commit message in GitHub? It might make a little more sense to people to have that information rather than the JSON object. Thanks!

Hey thanks for suggestion, but unfortunately its not possible.

Currently while running action there are some environment variables bydefault available and commit message is not one of them

since Sha is available we can retrieve commit message with Github API

and problem with using Github API is rate-limiting

Since this api request will be made form Github runner, it will be considered as unauthenticated request which has limit of 60 requests per hour. so if you are using any other actions within your workflow which uses Github apis this limit will exceed immediately. Another approach is take user token as input for action to make authenticated request. but this requires all existing users to modify their workflow.

@AmrutaKawade
Copy link
Contributor

AmrutaKawade commented Mar 9, 2021

I tried to retrieve commit message as mentioned here

https://stackoverflow.com/questions/63619329/github-action-get-commit-message

image

image

But its not available.
So I am going ahead with current fix.

@AmrutaKawade
Copy link
Contributor

I have released this fix and you can verify with v2 tag. but strange thing is Deployment Center UI seems to be changed.
image

@spellegrino021
Copy link
Collaborator

I have released this fix and you can verify with v2 tag. but strange thing is Deployment Center UI seems to be changed.
image

Yes we recently changed the UI so if you are set up with Azure Pipelines you will see the classic Deployment Center.

@AmrutaKawade
Copy link
Contributor

since this is released will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants