Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add independent completion for categories and tags #303

Closed
wants to merge 1 commit into from

Conversation

CendioOssman
Copy link
Contributor

They are often not bound to specific activities so make sure all
recent ones are suggested. This is even more important when entering
a previously unseen activity.

They are often not bound to specific activities so make sure all
recent ones are suggested. This is even more important when entering
a previously unseen activity.
@CendioOssman
Copy link
Contributor Author

I assume the same fix is needed for the extension.

@axmachado
Copy link

It looks interesting... will try to test it.

@elbenfreund
Copy link
Contributor

elbenfreund commented Jul 6, 2016

Thank you for your feedback, it is much appreciated.

Project hamster and its various sub-components is currently undergoing some major changes. We prepare the introduction of a rewritten codebase for most of the underlying functionality. A direct consequence of this is that it is unlikely that any open/new bugs within the current/old codebase will be fixed (unless someone steps up and offers to do so) as most resources currently available will be invested in making the rewrite prime time ready.

If you are still interested in working on the new codebase (repositories: hamster-lib/cli/gtk/dbus) we would be most thrilled. Please feel free to either open a new issue with the relevant repository and/or join the discussion on the mailinglist.
For more context please see our website.

Thanks for your interest and support! Eric.

@ederag ederag self-assigned this Dec 23, 2018
@ederag
Copy link
Collaborator

ederag commented Dec 30, 2018

After a tentative merge:
https://github.com/ederag/hamster/tree/CendioOssman-completion
it increases the code duplication (with hamster.lib.Fact and parse_fact)
already present in the common ancestor.
And it might be because of wrong choices during merge
(please help if it is the case),
but it is impossible to search specifically for a tag by typing # as the first letter,
while this is possible in current master.
It does not find tags in the auto-completion configuration,
but both versions find "unseen" activities.

So it seems that the issues this PR was intending to solve
have been resolved in another way by PR #363.
Please comment here if I missed anything.

Your work was useful though,
because the separation between activity, category and tags searches is very interesting,
and besides, it has surely been silently been used by others meanwhile.
So thanks a lot for your contribution !

@ederag ederag closed this Dec 30, 2018
@ederag
Copy link
Collaborator

ederag commented Dec 30, 2018

related: #12

@CendioOssman
Copy link
Contributor Author

I think this is still needed in some form. This is just based on looking at the current code though, I haven't tested anything.

Please re-open the PR and I'll update the branch to something that works with the existing code.

@ederag
Copy link
Collaborator

ederag commented Jan 2, 2019

Please open another PR instead.

Some comments before you start coding:

  1. Please start by identifying clear use cases where the current code fails.
    We need to gather a bunch of tests anyway.
  2. Searching for category or tags separately is possible now:
    just start the search with @ or # respectively
  3. What does not work well is to search for two tags,
    because they have to be given in the correct order to be found.
    The search for tags should not depend on the order.
    Or could it be useful for some users to have some "priority" order ?
  4. Make sure to start with an up to date master, containing a9a6436
    (described in PR Keep input order of tag list #371), since keeping the order of tags is relevant here.
  5. There is still a lot of code duplication with hamster.lib.__init__.py,
    that should be removed in the process.
    (search should be based on facts fields)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants