Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No completion for category (regression) #301

Closed
CendioOssman opened this issue Mar 2, 2016 · 10 comments · Fixed by #461
Closed

No completion for category (regression) #301

CendioOssman opened this issue Mar 2, 2016 · 10 comments · Fixed by #461
Labels

Comments

@CendioOssman
Copy link
Contributor

The 2.x overview window seems to have lost the auto-completion for categories, which makes it very difficult to get them right. It doesn't work in the shell extension either so there's no workaround there.

@ederag
Copy link
Collaborator

ederag commented Jan 5, 2019

Thanks for the report.
Auto-completion for categories is back now, with limitations described in #303 (comment).

@ederag ederag closed this as completed Jan 5, 2019
@CendioOssman
Copy link
Contributor Author

I decided to have another go at upgrading from 1.04, but this seems to still be broken in 2.2.2. Could we reopen? Or was this fixed after the latest release?

@CendioOssman
Copy link
Contributor Author

For clarity, this is how 1.04 behaves:

2019-09-03-152217_3840x1200_scrot

In 2.2.2 absolutely nothing happens when I type @ and start filling out a category.

@GeraldJansen
Copy link
Contributor

A comment rather than a definitive answer: AFAIK, there is no such category completion in current master. However, once you have created activity@category combinations a first time, say b232@ThinLine/Consulting and b232@ThinLine/Support, the next time you start typing b232 both category completions will be given in the suggestion list. Also if you type @Thi at the start of the input line, recent matching activies will be shown. I use similar client/project categories and this works quite well for me.

@ederag
Copy link
Collaborator

ederag commented Sep 3, 2019

@GeraldJansen exactly, that's why I closed this.
For activities@categories used in the past month, it just fine
(including searching for category alone, just start with @).

Yet it would be really nice to add existing categories (and activities, and tags) to completion search
for new or seldom used items. Reopening.

@ederag ederag reopened this Sep 3, 2019
@CendioOssman
Copy link
Contributor Author

Great, then we should be on the same page. :)

I think #303 fixes this, but it was ages ago I wrote that. I'll try to have a look at getting it updated for the current master and put up a new PR.

@ederag
Copy link
Collaborator

ederag commented Sep 4, 2019

Thanks for helping again !
I don't know if it will be possible to fix that by a minimal change.
If the change is as large as #303,
then it would be good to replace most of the code duplication by exploiting Fact.
(that was the point 5 of this comment).
The testing and review time will probably be similar either way.
I'm almost ready to send a PR about Fact itself (it should be cleaner), so please do not touch it,
but no need to wait for that.

@ederag ederag mentioned this issue Oct 5, 2019
4 tasks
@ederag
Copy link
Collaborator

ederag commented Oct 5, 2019

Hopefully fixed with PR #461.
Please provide feedback there.

@ederag
Copy link
Collaborator

ederag commented Oct 30, 2019

@CendioOssman That was an automatic close from #461.
It is very clear now that you would also like completion in the cmdline.
v2 did focus cmdline completion on previous activities,
which results in much quicker inputs most of the time.
Completions on a pre-defined list was completely lost, indeed.

Regarding the initial post, there is now a way to enter categories with completion,
by using the separated fields introduced in #461.
The workflow is described here.
So I'm leaving this closed.

If after using it for a while you would still think
that the associated complications are surpassed by the usage gain,
then please file a new issue.

@CendioOssman
Copy link
Contributor Author

Alright. I'll try it for a while and see how it feels. Thanks for your attention in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants