Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: regenerate after client-go v9.0.0 / kubernetes v1.12.6 #994

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

unicell
Copy link
Contributor

@unicell unicell commented Apr 9, 2019

Fixes #993

For the k8s version bump in the following commit
6110213 CRD apis needs to be
regenerated

Signed-off-by: Qiu Yu [email protected]

Fixes projectcontour#993

For the k8s version bump in the following commit
6110213 CRD apis needs to be
regenerated

Signed-off-by: Qiu Yu <[email protected]>
@davecheney
Copy link
Contributor

Thank you for your PR. Why do we need this, what is broken if I don't apply this?

@davecheney davecheney added this to the 0.12.0 milestone Apr 9, 2019
@unicell
Copy link
Contributor Author

unicell commented Apr 9, 2019

@davecheney Nothing breaks as I know of. It's mainly for catching up.

Thought it'd be great to keep it in sync with ingressroute.go. Otherwise whoever works on the CRD changes may found make updategenerated generates codes due to previous landed commits.

Copy link
Contributor

@davecheney davecheney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@davecheney davecheney merged commit c143d69 into projectcontour:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants