Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make updategenerated generates uncommitted code changes #993

Closed
unicell opened this issue Apr 9, 2019 · 0 comments
Closed

make updategenerated generates uncommitted code changes #993

unicell opened this issue Apr 9, 2019 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
0.12.0

Comments

@unicell
Copy link
Contributor

unicell commented Apr 9, 2019

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

After 6110213 commit, which did the version bump to client-go v9.0.0 / kubernetes v1.12.6, generated code under apis/ is lagging behind.

What did you expect to happen:

make updategenerated should not generate any code change locally

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Contour version:
  • Kubernetes version: (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
unicell added a commit to unicell/contour that referenced this issue Apr 9, 2019
@unicell
apis: regenerate after client-go v9.0.0 / kubernetes v1.12.6
d477b5c 
Fixes projectcontour#993

For the k8s version bump in the following commit
6110213 CRD apis needs to be
regenerated

Signed-off-by: Qiu Yu <[email protected]>
@unicell unicell mentioned this issue Apr 9, 2019
Merged
@davecheney davecheney added this to the 0.12.0 milestone Apr 9, 2019
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 9, 2019
davecheney added a commit that referenced this issue Apr 14, 2019
@davecheney
Merge branch 'gh-993' of ssh://github.com/glerchundi/contour into gle…
8f74082 
…rchundi-gh-993
davecheney added a commit that referenced this issue Apr 14, 2019
@davecheney
Merge branch 'glerchundi-gh-993'
f4932bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@davecheney @unicell