Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8] internal/k8s: Change StatusUpdaterHandler channel to buffered #2867

Merged

Conversation

youngnick
Copy link
Member

Updates #2857.

This should ensure that the DAG has some headroom before
status updates start blocking the DAG rebuilds, even in
reasonably busy clusters.

Signed-off-by: Nick Young [email protected]

…tcontour#2866)

Updates projectcontour#2857.

This should ensure that the DAG has some headroom before
status updates start blocking the DAG rebuilds, even in
reasonably busy clusters.

Signed-off-by: Nick Young <[email protected]>
@youngnick youngnick self-assigned this Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #2867 into release-1.8 will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.8    #2867   +/-   ##
============================================
  Coverage        76.45%   76.45%           
============================================
  Files               73       73           
  Lines             5712     5712           
============================================
  Hits              4367     4367           
  Misses            1259     1259           
  Partials            86       86           
Impacted Files Coverage Δ
internal/k8s/statusupdater.go 20.61% <0.00%> (ø)

Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngnick
Copy link
Member Author

SNI enforcment check has flaked again, ignoring.

@youngnick youngnick merged commit 3e2f25a into projectcontour:release-1.8 Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants