Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/k8s: Change StatusUpdaterHandler channel to buffered #2866

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

youngnick
Copy link
Member

Updates #2857.

This should ensure that the DAG has some headroom before
status updates start blocking the DAG rebuilds, even in
reasonably busy clusters.

Signed-off-by: Nick Young [email protected]

@youngnick youngnick self-assigned this Sep 2, 2020
Updates projectcontour#2857.

This should ensure that the DAG has some headroom before
status updates start blocking the DAG rebuilds, even in
reasonably busy clusters.

Signed-off-by: Nick Young <[email protected]>
@youngnick youngnick force-pushed the buffer-status-channel branch from 76518d2 to a530ff6 Compare September 2, 2020 00:31
@youngnick youngnick changed the title Change StatusUpdaterHandler channel to buffered internal/k8s: Change StatusUpdaterHandler channel to buffered Sep 2, 2020
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #2866 into main will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
+ Coverage   76.46%   76.49%   +0.03%     
==========================================
  Files          77       77              
  Lines        5833     5833              
==========================================
+ Hits         4460     4462       +2     
+ Misses       1278     1277       -1     
+ Partials       95       94       -1     
Impacted Files Coverage Δ
internal/k8s/statusupdater.go 20.61% <0.00%> (ø)
internal/dag/cache.go 97.64% <0.00%> (+0.78%) ⬆️

@youngnick youngnick merged commit ce3c5e4 into projectcontour:main Sep 2, 2020
youngnick pushed a commit to youngnick/contour that referenced this pull request Sep 2, 2020
…tcontour#2866)

Updates projectcontour#2857.

This should ensure that the DAG has some headroom before
status updates start blocking the DAG rebuilds, even in
reasonably busy clusters.

Signed-off-by: Nick Young <[email protected]>
youngnick pushed a commit that referenced this pull request Sep 2, 2020
…#2867)

Updates #2857.

This should ensure that the DAG has some headroom before
status updates start blocking the DAG rebuilds, even in
reasonably busy clusters.

Signed-off-by: Nick Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants