-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples and documentation for contour 1.5.1 with envoy 1.14.2 #2580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Peach <[email protected]>
Signed-off-by: Tim Bart <[email protected]>
Looks like I don't know how to help with a release 😞 |
youngnick
pushed a commit
to youngnick/contour
that referenced
this pull request
Jun 19, 2020
Updates the DAG StatusClient to use the StatusUpdateWriter pattern. Fixes projectcontour#2560 Fixes projectcontour#2580 Fixes projectcontour#2522 We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly. Signed-off-by: Nick Young <[email protected]>
youngnick
pushed a commit
to youngnick/contour
that referenced
this pull request
Jun 19, 2020
Updates the DAG StatusClient to use the StatusUpdateWriter pattern. Fixes projectcontour#2560 Fixes projectcontour#2580 Fixes projectcontour#2522 We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly. Signed-off-by: Nick Young <[email protected]>
youngnick
pushed a commit
to youngnick/contour
that referenced
this pull request
Jun 19, 2020
Updates the DAG StatusClient to use the StatusUpdateWriter pattern. Fixes projectcontour#2560 Fixes projectcontour#2580 Fixes projectcontour#2522 We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly. Signed-off-by: Nick Young <[email protected]>
youngnick
pushed a commit
to youngnick/contour
that referenced
this pull request
Jun 19, 2020
Updates the DAG StatusClient to use the StatusUpdateWriter pattern. Fixes projectcontour#2560 Fixes projectcontour#2580 Fixes projectcontour#2522 We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly. Signed-off-by: Nick Young <[email protected]>
youngnick
pushed a commit
to youngnick/contour
that referenced
this pull request
Jun 19, 2020
Updates the DAG StatusClient to use the StatusUpdateWriter pattern. Fixes projectcontour#2560 Fixes projectcontour#2580 Fixes projectcontour#2522 We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly. Signed-off-by: Nick Young <[email protected]>
youngnick
pushed a commit
to youngnick/contour
that referenced
this pull request
Jun 19, 2020
Updates the DAG StatusClient to use the StatusUpdateWriter pattern. Fixes projectcontour#2560 Fixes projectcontour#2580 Fixes projectcontour#2522 We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly. Signed-off-by: Nick Young <[email protected]>
youngnick
pushed a commit
that referenced
this pull request
Jun 19, 2020
Updates the DAG StatusClient to use the StatusUpdateWriter pattern. Fixes #2560 Fixes #2580 Fixes #2522 We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under #2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly. Signed-off-by: Nick Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is based off
v.1.5.0
and doesn't contain any code change besides examples and documentation.I believe that the only thing missing is the tag.