Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Update DAG status updates to go via k8s/StatusUpdateHandler #2560

Closed
youngnick opened this issue May 28, 2020 · 1 comment · Fixed by #2613
Closed

internal: Update DAG status updates to go via k8s/StatusUpdateHandler #2560

youngnick opened this issue May 28, 2020 · 1 comment · Fixed by #2613
Assignees
@youngnick
Labels
area/status Issues or PRs related to exposing status for APIs. blocked Blocked waiting on a dependency kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@youngnick
Copy link
Member

youngnick commented May 28, 2020 •
edited
Loading

Move the existing DAG rebuild status updates to use StatusUpdateHandler, including adding support for IngressRoute and HTTPProxy valid and desc fields. This may involve a small update to IngressRoute to enable the status subresource, so that the same code paths can be used for everything.

Work initially part of #2371, but pulled out because it's bigger than I thought.
@youngnick youngnick added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/status Issues or PRs related to exposing status for APIs. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid. labels May 28, 2020
@youngnick youngnick self-assigned this May 28, 2020
@jpeach jpeach mentioned this issue May 28, 2020
Closed
3 tasks
@youngnick youngnick mentioned this issue Jun 8, 2020
Closed
@youngnick youngnick added the blocked Blocked waiting on a dependency label Jun 9, 2020
@youngnick
Copy link
Member Author

Blocked on #2572.

youngnick pushed a commit to youngnick/contour that referenced this issue Jun 19, 2020
Send DAG status updates via StatusUpdateHandler
d6851c5 
Updates the DAG StatusClient to use the StatusUpdateWriter pattern.

Fixes projectcontour#2560
Fixes projectcontour#2580
Fixes projectcontour#2522

We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly.

Signed-off-by: Nick Young <[email protected]>
youngnick pushed a commit to youngnick/contour that referenced this issue Jun 19, 2020
Send DAG status updates via StatusUpdateHandler
86d8355 
Updates the DAG StatusClient to use the StatusUpdateWriter pattern.

Fixes projectcontour#2560
Fixes projectcontour#2580
Fixes projectcontour#2522

We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly.

Signed-off-by: Nick Young <[email protected]>
@youngnick youngnick mentioned this issue Jun 19, 2020
Merged
youngnick pushed a commit to youngnick/contour that referenced this issue Jun 19, 2020
Send DAG status updates via StatusUpdateHandler
7244bae 
Updates the DAG StatusClient to use the StatusUpdateWriter pattern.

Fixes projectcontour#2560
Fixes projectcontour#2580
Fixes projectcontour#2522

We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly.

Signed-off-by: Nick Young <[email protected]>
youngnick pushed a commit to youngnick/contour that referenced this issue Jun 19, 2020
Send DAG status updates via StatusUpdateHandler
1939d6f 
Updates the DAG StatusClient to use the StatusUpdateWriter pattern.

Fixes projectcontour#2560
Fixes projectcontour#2580
Fixes projectcontour#2522

We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly.

Signed-off-by: Nick Young <[email protected]>
youngnick pushed a commit to youngnick/contour that referenced this issue Jun 19, 2020
Send DAG status updates via StatusUpdateHandler
36f62e8 
Updates the DAG StatusClient to use the StatusUpdateWriter pattern.

Fixes projectcontour#2560
Fixes projectcontour#2580
Fixes projectcontour#2522

We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly.

Signed-off-by: Nick Young <[email protected]>
youngnick pushed a commit to youngnick/contour that referenced this issue Jun 19, 2020
Send DAG status updates via StatusUpdateHandler
203fe82 
Updates the DAG StatusClient to use the StatusUpdateWriter pattern.

Fixes projectcontour#2560
Fixes projectcontour#2580
Fixes projectcontour#2522

We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly.

Signed-off-by: Nick Young <[email protected]>
youngnick pushed a commit that referenced this issue Jun 19, 2020
Send DAG status updates via StatusUpdateHandler (#2613)
7da4e29 
Updates the DAG StatusClient to use the StatusUpdateWriter pattern.

Fixes #2560
Fixes #2580
Fixes #2522

We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under #2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly.

Signed-off-by: Nick Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youngnick youngnick

Labels
area/status Issues or PRs related to exposing status for APIs. blocked Blocked waiting on a dependency kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send DAG status updates via StatusUpdateHandler youngnick/contour
1 participant
@youngnick