Bump deps #380
Open
Bump deps #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes things installable a bit better
|
I gave my 50cent via chat. The essence of it is: please make sure mypy never ignores wsgidav because it is used to detect if upstream makes incompatible changes to parent classes. So it would be good to avoid ignore_missing_imports. |
|
I asked gpt if requesting wsgidav to add py.typed is the correct approach. Since wsgidav is actually fully typed. This would allow to remove mymy_fix.py. https://typing.readthedocs.io/en/latest/spec/distributing.html#type-information-in-libraries Above is the current way to make a lib typed. |
Note regarding the `ignore`d super() call: mypy thinks that the `super()` call in `ManabiS3Provider.__init__()` goes to the direct base class `ManabiProvider` and is thus missing the required `root_folder` parameter, but this ain't so: This calls `DAVProvider.__init__()` which doesn't take that param. Then we add a bit of typing sugar and make mypy shut up about missing type information from 3rd party imports. A few smaller issues that mypy finds in CI but not locally are addressed as well.
Introduce a full-blown Ruff config (mostly stolen from Timed) that can replace the full black+isort+flake8(and plugins) suite that was used before. The changes here should not be functional or impact the type system at all (mypy is still there and watches over us)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.