-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Note regarding the `ignore`d super() call: mypy thinks that the `super()` call in `ManabiS3Provider.__init__()` goes to the direct base class `ManabiProvider` and is thus missing the required `root_folder` parameter, but this ain't so: This calls `DAVProvider.__init__()` which doesn't take that param. Then we add a bit of typing sugar and make mypy shut up about missing type information from 3rd party imports. A few smaller issues that mypy finds in CI but not locally are addressed as well.
- Loading branch information
Showing
2 changed files
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,6 +94,8 @@ commit_author = "github-actions <[email protected]>" | |
[tool.mypy] | ||
check_untyped_defs = true | ||
|
||
ignore_missing_imports = true | ||
|
||
[tool.flake8] | ||
ignore = """ | ||
E501, | ||
|