Check operator CRDs as part of ci preflight checks #9377
Merged
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
danudey
reviewed
Oct 22, 2024
caseydavenport
added
docs-not-required
marvin-tigera
removed
release-note-required
coutinhop
reviewed
Oct 22, 2024
coutinhop
reviewed
Oct 22, 2024
coutinhop
reviewed
Oct 22, 2024
coutinhop
reviewed
Oct 22, 2024
coutinhop
approved these changes
Oct 22, 2024
caseydavenport
force-pushed
the
casey-check-operator-crds
branch
from
7ab5081
to
56de958
Compare
caseydavenport
force-pushed
the
casey-check-operator-crds
branch
from
56de958
to
0747a6c
Compare
radTuti
pushed a commit
to radTuti/calico
that referenced
this pull request
Nov 26, 2024
radTuti
pushed a commit
to radTuti/calico
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8883
This PR will fail CI if the operator CRDs are not in sync.
This is potentially annoying, as it means we may need to push some
unrelated changes into PRs to get CI working. But I think it is worth
the friction to avoid these getting out of sync.
We have encountered release problems in the past where we shipped
operator CRDs that were out of date.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.