Helm chart does not have proper updates from operator repo for operator types

[tmjd]

Expected Behavior

The helm chart and manifest should have updates pulled from the operator repo before each release.

Current Behavior

Master and Calico v3.28 are not updated with the proper definitions for the operator types. A specific example looking at the v3.28 release, is csi-node-driver is the only allowed container name for the csiNodeDriverDaemonSet but csi-node-driver-registrar and csi-node-driver should also be allowed (based on the CRD in the operator repo). See tigera/operator#3356 for context.

Possible Solution

Ensure the release process properly pulls in updates from the operator repo before creating new releases. It will also be good to pull in updates to the master branch periodically or anytime creating new releases.

Steps to Reproduce (for bugs)

This is an issue with getting the manifests/helm chart updated properly for releases, so no steps necessary to reproduce.

Context

tigera/operator#3356

Your Environment

Not Applicable

[mashiofu-cafex]

Originated from #8853 which is now closed to monitor this issue

[muckelba]

We've stumbled across the same problem. I've tried to use the original yaml from the operator repo, but that's not perfect yaml:

kubectl apply --server-side --force-conflicts -f https://github.com/tigera/operator/blob/master/pkg/crds/operator/operator.tigera.io_installations.yaml
error: error parsing https://github.com/tigera/operator/blob/master/pkg/crds/operator/operator.tigera.io_installations.yaml: error converting YAML to JSON: yaml: line 212: mapping values are not allowed in this context

[TomBillietKlarrio]

Any updates on this? Just stumbled upon it too.

[mashiofu-cafex]

Any update on this effort?

[caseydavenport]

There's a makefile helper to do this:

calico/Makefile

Lines 65 to 70 in bb0c3b9

	# Get operator CRDs from the operator repo, OPERATOR_BRANCH_NAME must be set
	get-operator-crds: var-require-all-OPERATOR_BRANCH_NAME
	cd ./charts/tigera-operator/crds/ && \
	for file in operator.tigera.io_*.yaml; do echo "downloading $$file from operator repo" && curl -fsSL https://raw.githubusercontent.com/tigera/operator/${OPERATOR_BRANCH_NAME}/pkg/crds/operator/$${file%_crd.yaml}.yaml -o $${file}; done
	cd ./manifests/ocp/ && \
	for file in operator.tigera.io_*.yaml; do echo "downloading $$file from operator repo" && curl -fsSL https://raw.githubusercontent.com/tigera/operator/${OPERATOR_BRANCH_NAME}/pkg/crds/operator/$${file%_crd.yaml}.yaml -o $${file}; done

This PR will add a CI check for it: #9377