Add a resolveEnvVars option to .zap package.pathRelativity #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows variables like $CHIP_ROOT to be used, which is needed when the chip codebase is a submodule of the repository the zap file is in. Throw an error when any variable used fails resolving.
brdandu
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows variables like $CHIP_ROOT to be used, which is needed when the chip codebase is independent to the repository the zap file is in.
Throw an error when any variable used fails resolving.
PR implementing this in connectedhomeip.git/scripts/generate.py: project-chip/connectedhomeip#24482