-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zap/generate.py: add resolveEnvVars pathRelativity #24482
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
q-thla:pr/add-resolveenvvars-pathrelativity
Jan 25, 2023
Merged
zap/generate.py: add resolveEnvVars pathRelativity #24482
yufengwangca
merged 2 commits into
project-chip:master
from
q-thla:pr/add-resolveenvvars-pathrelativity
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
January 18, 2023 09:04
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 18, 2023 09:04
PR #24482: Size comparison from c5cb0dd to e08d644 Increases (11 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 18, 2023
bzbarsky-apple
approved these changes
Jan 19, 2023
jmartinez-silabs
approved these changes
Jan 23, 2023
This allows the .zap's package pathRelativity to be set to resolveEnvVars , making it perform environment variable subsitution on the path given. This allows variables like $CHIP_ROOT to be used, which is needed when the chip codebase is independent to the repository the zap file is in.
q-thla
force-pushed
the
pr/add-resolveenvvars-pathrelativity
branch
from
January 25, 2023 13:59
bd9e1cb
to
e1752cb
Compare
PR #24482: Size comparison from 612fc1c to e1752cb Increases (2 builds for nrfconnect, psoc6)
Decreases (3 builds for esp32, telink)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* zap/generate.py: add resolveEnvVars pathRelativity This allows the .zap's package pathRelativity to be set to resolveEnvVars , making it perform environment variable subsitution on the path given. This allows variables like $CHIP_ROOT to be used, which is needed when the chip codebase is independent to the repository the zap file is in. * zap/generate.py: Add clarity wrt prefix_chip_root_dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the .zap's package pathRelativity to be set to resolveEnvVars , making it perform environment variable subsitution on the path given.
This allows variables like $CHIP_ROOT to be used, which is needed when the chip codebase is independent to the repository the zap file is in.
PR implementing this feature in zap as well: project-chip/zap#891