fix to avoid looping indefinitely when moving to finalValue when equal to current value #9776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
changed the title
mkardous-silabs
changed the title
…ue when equal to currentValue
mkardous-silabs
force-pushed
the
fix/max_transition_time
branch
from
f240602 to
dc08bd7
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst and
shana-apple
pullapprove
bot
requested review from
turon,
vivien-apple,
woody-apple,
yufengwangca and
yunhanw-google
Checks if transitionTime is equal 0 after calculations
jmartinez-silabs
approved these changes
Sep 17, 2021
Damian-Nordic
approved these changes
Sep 17, 2021
andy31415
approved these changes
Sep 17, 2021
mleisner
pushed a commit
to mleisner/connectedhomeip
that referenced
this pull request
Sep 20, 2021
…l to current value (project-chip#9776) * fix to avoid looping indefinitely when requesting to move to finalValue when equal to currentValue * Moved fix to cover more cases Checks if transitionTime is equal 0 after calculations * restyle * changed check to remove max function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When calculating transitionTime from current value and final value, if current and final value are equal, transitionTime ends up being equal to 0 and causes the application to indefinitely try to get to the final value when current value is equal to the final value.
Change overview
Added a check when calculating transitionTime that if current value and final value are the same, sets the transitionTime to 1. This forces the normal execution to happen for one iteration.
Testing