fix to avoid looping indefinitely when requesting to move to finalVal…

…ue when equal to currentValue
project-chip · Sep 17, 2021 · dc08bd7 · dc08bd7
1 parent 3178a47
commit dc08bd7
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/src/app/clusters/color-control-server/color-control-server.cpp b/src/app/clusters/color-control-server/color-control-server.cpp
@@ -231,9 +231,17 @@ uint16_t ColorControlServer::computeTransitionTimeFromStateAndRate(ColorControlS
         min = p->currentValue;
     }
 
-    transitionTime = max - min;
-    transitionTime *= 10;
-    transitionTime /= rate;
+    // If currentValue == finalValue, force 1 step
+    if (max == min)
+    {
+        transitionTime = 1;
+    }
+    else
+    {
+        transitionTime = max - min;
+        transitionTime *= 10;
+        transitionTime /= rate;
+    }
 
     if (transitionTime > MAX_INT16U_VALUE)
     {