Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes transitionTime type for stepHue and stepTransition #9767

Merged

Conversation

mkardous-silabs
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

  • changed type for transitionTime and regenerated files

Testing

  • Automated testing to check that the commands where still functionnal

@github-actions
Copy link

Size increase report for "esp32-example-build" from 3178a47

File Section File VM
chip-all-clusters-app.elf .flash.text 12 12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,62
.debug_info,0,50
.flash.text,12,12
.riscv.attributes,0,2
.debug_loc,0,-2
[Unmapped],0,-12


@woody-apple woody-apple merged commit ebd8b3b into project-chip:master Sep 17, 2021
mleisner pushed a commit to mleisner/connectedhomeip that referenced this pull request Sep 20, 2021
…hip#9767)

* Changes transitionTime to uint16_t from uint8_t

* Generated files
@mkardous-silabs mkardous-silabs deleted the fix/callback_parameter branch October 19, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants