-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert transitionTime type for stepHue and stepTransition #10014
Merged
andy31415
merged 4 commits into
project-chip:master
from
mkardous-silabs:fix/revert_transtion_time_type
Sep 28, 2021
Merged
Revert transitionTime type for stepHue and stepTransition #10014
andy31415
merged 4 commits into
project-chip:master
from
mkardous-silabs:fix/revert_transtion_time_type
Sep 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
shana-apple
September 28, 2021 14:01
pullapprove
bot
requested review from
turon,
vivien-apple,
woody-apple and
yunhanw-google
September 28, 2021 14:01
msandstedt
approved these changes
Sep 28, 2021
saurabhst
approved these changes
Sep 28, 2021
bzbarsky-apple
approved these changes
Sep 28, 2021
Damian-Nordic
approved these changes
Sep 28, 2021
woody-apple
approved these changes
Sep 28, 2021
andy31415
approved these changes
Sep 28, 2021
Size increase report for "esp32-example-build" from 083c9ad
Full report output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #9767 did not respect spec type for transitionTime for stepHue and stepSaturation
Change overview
Changed transitionTime to uint8 as specified by the spec
Testing
Manual testing to check that Color Control commands are functionnal