Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert transitionTime type for stepHue and stepTransition #10014

Merged

Conversation

mkardous-silabs
Copy link
Contributor

Problem

PR #9767 did not respect spec type for transitionTime for stepHue and stepSaturation

Change overview

Changed transitionTime to uint8 as specified by the spec

Testing

Manual testing to check that Color Control commands are functionnal

@woody-apple
Copy link
Contributor

@Damian-Nordic ?

@github-actions
Copy link

Size increase report for "esp32-example-build" from 083c9ad

File Section File VM
chip-all-clusters-app.elf .flash.text -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,12
.debug_loc,0,2
.riscv.attributes,0,-2
.flash.text,-12,-12
.debug_info,0,-50
.debug_line,0,-62


@andy31415 andy31415 merged commit a152ba7 into project-chip:master Sep 28, 2021
@mkardous-silabs mkardous-silabs deleted the fix/revert_transtion_time_type branch September 28, 2021 19:30
@mkardous-silabs mkardous-silabs restored the fix/revert_transtion_time_type branch September 28, 2021 19:30
@mkardous-silabs mkardous-silabs deleted the fix/revert_transtion_time_type branch October 19, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants