Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Stop using destroyed fragment in pairing complete callback #9729

Merged
merged 1 commit into from
Sep 17, 2021
Merged

[Android] Stop using destroyed fragment in pairing complete callback #9729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,13 @@ class DeviceProvisioningFragment : Fragment() {
override fun onPairingComplete(code: Int) {
Log.d(TAG, "onPairingComplete: $code")

// In IP commissioning, commissioning complete will already be called at this point, and the
// next fragment will be shown. As a result, this fragment will be in a destroyed state and
// should not be operated on.
if (deviceInfo.ipAddress != null) {
austinh0 marked this conversation as resolved.
Show resolved Hide resolved
return
}

if (code == STATUS_PAIRING_SUCCESS) {
childFragmentManager.beginTransaction()
.add(R.id.fragment_container, EnterNetworkFragment.newInstance(networkType))
Expand Down