[Android] Stop using destroyed fragment in pairing complete callback #9729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
bzbarsky-apple
approved these changes
Sep 15, 2021
woody-apple
approved these changes
Sep 16, 2021
|
@project-chip/reviewers-amazon @project-chip/reviewers-google @project-chip/reviewers-comcast @project-chip/reviewers-samsung ? |
pullapprove
bot
requested review from
cecille,
emargolis,
harimau-qirex,
holbrookt,
jelderton,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
saurabhst,
turon,
yufengwangca and
yunhanw-google
emargolis
approved these changes
Sep 16, 2021
Damian-Nordic
approved these changes
Sep 16, 2021
...IPTool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
Show resolved
Hide resolved
jmartinez-silabs
approved these changes
Sep 16, 2021
LuDuda
approved these changes
Sep 16, 2021
mleisner
pushed a commit
to mleisner/connectedhomeip
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DeviceProvisioningFragment, if pairing complete is called after commissioning complete, it will try to access the already-destroyed DeviceProvisioningFragment's fragmentManager.Change overview
Testing