-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making py chip-device-ctrl discoverable over DNS-SD as a commissioner #9603
Conversation
b0ea795
to
4e1caad
Compare
4e1caad
to
2af778c
Compare
2af778c
to
731f5b8
Compare
Some of those issues are duplicates that were never actually assigned. Ex. multiple operational adverts are supported and have been tested. Please see TestAdvertiser.cpp and TestPlatform.cpp. |
Problem
For a Matter Test event, we need to run the python chip-device-ctrl tool on a raspi and test the tv-casting-app against it. For this the tool needs to be discoverable over DNS-SD as a commissioner (It already accepts UDC requests and has the connect command to do onnetwork commissioning)
Change overview
With this change, the python chip-device-ctrl tool will start advertising itself as a commissioner on start-up behind a feature flag: CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONER_DISCOVERY.
TBD: Code to set the flag CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONER_DISCOVERY to 1 for just the python chip-device-ctrl tool will follow separately.
Testing
Tested with the CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONER_DISCOVERY set to 1. Used the minimal-mdns client to ensure the python chip-device-ctrl tool is discoverable as a commissioner device